Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another mutant meat exploit #35691

Merged
merged 2 commits into from
Nov 24, 2019

Conversation

Davi-DeGanne
Copy link
Contributor

@Davi-DeGanne Davi-DeGanne commented Nov 24, 2019

Summary

SUMMARY: None

Purpose of change

There was an unintended behavior where if you made mutant meat into jerky, then made something using that jerky, it would not inherit the negative effects of mutant meat.

This was caused by jerky inheriting cooks_like from meat.

Describe the solution

Got rid of jerky's cooks_like (and other superfluous properties) by making it inherit from the abstract type flesh instead of meat. Added "price": 320 and removed proportional price entry, since flesh doesn't have its own price entry. Removed healthy property as that was now redundant due to being inherited from flesh.

Describe alternatives you've considered

Testing

Additional context

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks labels Nov 24, 2019
@ZhilkinSerg ZhilkinSerg merged commit 98f4b5c into CleverRaven:master Nov 24, 2019
@Davi-DeGanne Davi-DeGanne deleted the exploit-fix branch November 24, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants