Fixed terminal settings saving #35694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
game_ui::init_ui() is doing much more than redrawing. Discard handle_redraw(). Fixes CleverRaven#35631.
ZhilkinSerg
added
[C++]
|
I'm not good at all with all this SDL stuff. If |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixed terminal settings saving"Purpose of change
Fixes #35631.
Describe the solution
Replace
handle_redraw()calls withcatacurses::refresh()calls.game_ui::init_ui()is doing much more than redrawing.Discard
handle_redraw()function.Describe alternatives you've considered
It might be that
catacurses::refresh()is not a best option here.Testing
Changing terminal width/height from the options when world is loaded or isn't loaded works.
Screen redraws as expected it seems.
@Night-Pryanik take a look, please, as this technically reverts some of your changes in #35157 and #35553.