Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop NPC asking for tool selection when repairing #35697

Merged
merged 1 commit into from Nov 25, 2019
Merged

Stop NPC asking for tool selection when repairing #35697

merged 1 commit into from Nov 25, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 24, 2019

Summary

SUMMARY: Bugfixes "Stop NPC asking for tool selection when repairing"

Purpose of change

Fixes #35261

Describe the solution

Instead of NPC prompting for which tool to use when they have multiple, just tell them to use whatever is the first choice, it dosnt really matter so much which one they use.

Describe alternatives you've considered

N.A

Testing

Tested before change - NPC with torch and welder, went to repair vehicle - prompted with a menu to choose which tool.

After this change - NPC did the repair without prompting and chose one of the tools

Additional context

N/A

@Funguss
Copy link
Contributor

Funguss commented Nov 24, 2019

Huh... Not sure I like this too much. I don't want them using my superglue instead of duct tape when they repair my deathmobile! Or is it just tools?

@ghost
Copy link
Author

ghost commented Nov 24, 2019

Huh... Not sure I like this too much. I don't want them using my superglue instead of duct tape when they repair my deathmobile! Or is it just tools?

Both tools and components, if they were to work out how to prioritise which components to use when they had multiple to choose from, that would require a whole new thing, and is best done in another PR, this just removes the bug of a menu popping up for the player.

@Funguss
Copy link
Contributor

Funguss commented Nov 24, 2019

Ahh... I thought it was a feature! I'll guard my glue carefully.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Nov 25, 2019
@ZhilkinSerg ZhilkinSerg merged commit af655af into CleverRaven:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPC repair mechanic asks for tool selection
2 participants