Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang-tidy regression #35699

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Fix clang-tidy regression #35699

merged 1 commit into from
Nov 25, 2019

Conversation

ifreund
Copy link
Contributor

@ifreund ifreund commented Nov 24, 2019

Summary

SUMMARY: None

Purpose of change

Hit an unrelated clang tidy error in #35696 and thought I'd fix it

Describe the solution

Remove the const keyword as it does nothing in this case and hurts readability

@ifreund ifreund added Code: Build Issues regarding different builds and build environments [C++] Changes (can be) made in C++. Previously named `Code` labels Nov 24, 2019
@ZhilkinSerg ZhilkinSerg merged commit 9503d09 into CleverRaven:master Nov 25, 2019
@ifreund ifreund deleted the clang-tidy-regression branch November 25, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ifreund @ZhilkinSerg