Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop fix #35715

Merged
merged 6 commits into from
Nov 25, 2019
Merged

Workshop fix #35715

merged 6 commits into from
Nov 25, 2019

Conversation

eltank
Copy link
Contributor

@eltank eltank commented Nov 25, 2019

Summary

SUMMARY: Bugfixes "Make basecamp modular workshop usable"

Purpose of change

I noticed that the modular workshop added in #34156 is not actually usable, i.e. you can't tell NPCs to craft any of the workshop recipes that it's supposed to provide via the expansion menu. In fact, after you finish building all the modular upgrades, you can't even Tab over to the expansion any more. This PR makes it so that the workshop recipes show up in the expansion menu.

Describe the solution

By comparing the json for the modular workshop with the json for the old blacksmith basecamp expansion, I noticed that it was missing "blueprint_provides": { "id": "blacksmith" }. I hacked that into my save file and the workshop became functional.
While editing the json files to apply the fix to the blueprint I noticed some unnecessary duplication so I created _common recipes and mapgens and did some refactoring. I also cleaned up some discrepancies between the tools being added to the workshop and the tools being made available as blueprint_resources, and I touched up some of the descriptions.

NOTE: The fix is not retroactive. Anyone who already built a modular workshop will not benefit from this (but scroll down for workaround).

Describe alternatives you've considered

Not refactoring and applying the same fixes 5 times for each workshop variant.

Testing

Play testing. Created a new world, built a base with a workshop without the fix. Repeat after applying the fix.

Additional context

Before:
before

After:
after

Instructions for save file hacking to enable crafting in an already built workshop (use at own risk).

  • Find the file that contains the JSON for your basecamp. Usually this is
    <game directory>/save/<world name>/o.0.0
  • Open in a text editor
  • Look for this text
    "provides":[{"id":"blacksmith_recipes_1","amount":1}
  • Replace with
    "provides":[{"id":"blacksmith","amount":1},{"id":"blacksmith_recipes_1","amount":1}

@curstwist
Copy link
Contributor

Looks good, thanks for cleaning up the duplicated entries! I must've removed blacksmith when trying to fix another error, good catch.

@curstwist curstwist added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Player Faction Base / Camp All about the player faction base/camp/site labels Nov 25, 2019
@ZhilkinSerg ZhilkinSerg merged commit a97bf92 into CleverRaven:master Nov 25, 2019
@Funguss
Copy link
Contributor

Funguss commented Nov 25, 2019

Very nicely done, and thanks for going to the trouble of detailing the save edit, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Player Faction Base / Camp All about the player faction base/camp/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants