Coarse correction to drench rate from precipitation #35750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
It looks like the frequency with which rainfall effects were applied to the player were not adjusted when turn durations were changed, so the rate at which a player went from dry to drenched for a given level of precipitation was accelerated a great deal.
Describe the solution
Simply bail out of the drench calculation in 5 turns out of 6 to return the drench rate to the former level.
Describe alternatives you've considered
I don't want to mess with the various formulas surrounding this, and AFAIK the rainfall accumulation for e.g. funnels has already been adjusted, so there is nowhere to place a higher-level override.
Testing
need to walk around in some rain with various outfits and note the time to achieve the fully drenched state.
This was last adjusted here: #15867
so that sets the target times.