Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coarse correction to drench rate from precipitation #35750

Merged
merged 2 commits into from
Nov 28, 2019

Conversation

kevingranade
Copy link
Member

@kevingranade kevingranade commented Nov 27, 2019

Summary

SUMMARY: None

Purpose of change

It looks like the frequency with which rainfall effects were applied to the player were not adjusted when turn durations were changed, so the rate at which a player went from dry to drenched for a given level of precipitation was accelerated a great deal.

Describe the solution

Simply bail out of the drench calculation in 5 turns out of 6 to return the drench rate to the former level.

Describe alternatives you've considered

I don't want to mess with the various formulas surrounding this, and AFAIK the rainfall accumulation for e.g. funnels has already been adjusted, so there is nowhere to place a higher-level override.

Testing

need to walk around in some rain with various outfits and note the time to achieve the fully drenched state.
This was last adjusted here: #15867
so that sets the target times.

src/weather.cpp Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Effects / Skills / Stats Effects / Skills / Stats Time / Turns / Duration / Date Issues concerning any activities being too fast or too slow. Also issues about time and date ingame Mechanics: Weather Rain, snow, portal storms and non-temperature environment labels Nov 28, 2019
@ZhilkinSerg ZhilkinSerg merged commit b60d185 into master Nov 28, 2019
@kevingranade kevingranade deleted the kevingranade-drench-rate branch December 16, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Effects / Skills / Stats Effects / Skills / Stats Mechanics: Weather Rain, snow, portal storms and non-temperature environment Time / Turns / Duration / Date Issues concerning any activities being too fast or too slow. Also issues about time and date ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants