Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deck of cards to gain morale with a game of solitaire activity #35780

Merged
merged 7 commits into from Nov 30, 2019
Merged

Add Deck of cards to gain morale with a game of solitaire activity #35780

merged 7 commits into from Nov 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2019

Summary

SUMMARY: Content "Add Deck of cards to gain morale with a game of solitaire activity"

Purpose of change

Add Deck of cards to gain morale with a game of solitaire activity

Describe the solution

Just add the item - add a new iuse, and a new activity that gains morale, add to some relevant itemgroups, thats it really.

Describe alternatives you've considered

N/A

Testing

Loaded game, spawned cards, activated them, did activity, gained a bit of morale.

Additional context

N/A

@Funguss
Copy link
Contributor

Funguss commented Nov 29, 2019

Can't wait to play poker with NPCs so they can win the shirt off my back!

@ghost
Copy link

ghost commented Nov 30, 2019

Can't wait to play poker with NPCs so they can win the shirt off my back!

Why let them win when you can pack the ballistic trump card in your sleeve?

Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
@Rail-Runner
Copy link
Contributor

Could this be generalized to represent any kind of game? Like chess, checkers, or whatever else people could come up with.

@ghost
Copy link
Author

ghost commented Nov 30, 2019

Could this be generalized to represent any kind of game? Like chess, checkers, or whatever else people could come up with.

I made the morale "MORALE_GAME" instead of "MORALE_VIDEO_GAME" so the text is more generic.

And thinking on it... yes I could make the iuse function generic "play game" and that means it could be re-used for other items that one could feasibly use to play a game solo.

Ill do that now.

@ghost
Copy link
Author

ghost commented Nov 30, 2019

There ive made the use action a generic "PLAY_GAME" that other stuff can use.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Mechanics: Character / Player Character / Player mechanics Items / Item Actions / Item Qualities Items and how they work and interact labels Nov 30, 2019
@ZhilkinSerg ZhilkinSerg merged commit 20e8354 into CleverRaven:master Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants