Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New JSON recipe property for overriding inheritance of specified flags #35825

Merged
merged 3 commits into from
Dec 4, 2019
Merged

New JSON recipe property for overriding inheritance of specified flags #35825

merged 3 commits into from
Dec 4, 2019

Commits on Dec 3, 2019

  1. Add JSON field to delete flags in recipes 

    My initial incarnation of flag inheritance included an item flag that
completely disabled flag inheritance when that item was crafted.
In retrospect, that was a poor solution. It is too heavy-handed in
practice. For instance, it doesn't allow recipes to inherit one flag as
normal, while removing another. This solution should be more practical.
    @Davi-DeGanne
    Davi-DeGanne committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    3d0c9f6 View commit details
    Browse the repository at this point in the history

  2. Remove obsolete NO_CRAFT_INHERIT flag 

    The new "delete_flags" property of recipes does everything it used to do
and more.
Also replaced all uses of NO_CRAFT_INHERIT with delete_flags property.
    @Davi-DeGanne
    Davi-DeGanne committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    9797825 View commit details
    Browse the repository at this point in the history

  3. Change flags_to_delete from vector to set 

    As suggested by BevapDin.
    @Davi-DeGanne
    Davi-DeGanne committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    6ef12ba View commit details
    Browse the repository at this point in the history