Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new 4-door Hatchback vehicle. #36584

Merged
merged 8 commits into from
Dec 31, 2019
Merged

Adds new 4-door Hatchback vehicle. #36584

merged 8 commits into from
Dec 31, 2019

Conversation

martin509
Copy link
Contributor

Summary

SUMMARY: Content "Adds new 4-door hatchback car"

Purpose of change

Being a bit of a car nut, I was slightly bothered by the fact that the car called a 'Hatchback' in game, car_mini, most closely resembles a 2-seat city car such as a Smart Fortwo, and not a larger 4-door hatchback that is usually associated with the term. This PR renames the old 2-seat Hatchback to 'City Car' and introduces a 4-door variant in its place.

Describe the solution

Adds a new car, car_hatch, a small 4 door hatchback that is essentially just car_mini extended to have an extra row of seats, with storage space being hatches instead of a trunk like on a normal car. car_hatch has a fuel capacity of 40L, a midpoint between the 20L of car_mini and the 60L of car, and roughly analogous to a real-life subcompact hatchback.
car_mini is renamed from 'Hatchback' to 'City Car'.

Spawning behavior of car_hatch and car_mini is as follows: car_hatch is roughly half as common as car, except for on highways where it's 1/3 as common. car_mini's spawn density is cut in half and is now a bit less common than the Beetle, to reflect the relative rarity of city cars in most of the US. I'm not 100% familiar with how these spawn rates are balanced, so feel free to suggest changes to this.

Testing

Loaded a large city map and verified that it spawned and had all the correct parts.

Additional context

image

image

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions labels Dec 31, 2019
@ZhilkinSerg ZhilkinSerg merged commit 31e1e8b into CleverRaven:master Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants