renovate house 04

[curstwist]

Summary

SUMMARY: Content "Adds roof and renovates house04"

Purpose of change

Begin the long process of updating the existing houses.

Describe the solution

For each house the following work needs to be done:

1. Add roof.
2. Add SUS groups for loot spawns.
3. Add dedicated downstairs access for basements.
4. Update terrains, add new furniture, and generally try to improve the map with small adjustments.

Describe alternatives you've considered

Using a dedicated housing palettes to make these uniform. I'm open to using my existing house_w series of palettes if other contributors prefer this approach. It'll take more 'translation' work on the existing maps.

Begin adding nested mapgen if I see an opportunity, but again this would considerably increase the time spent per house.

I've been trending away from a lot of metal furniture in domestic buildings because it doesn't seem to be very common in reality. This will impact crafting a fair amount so I wanted to mention it for discussion. For example, I favor wooden racks over the metal racks, which I imagine are a more commercial rack like in a grocery store.

Testing

Spawned in game.

Additional context

[ymber]

I'd like to see standard_building_palette and the house_w palettes used in all the houses. Nested chunks would be good but getting all the old houses modernized is more important first.

[curstwist]

I'd like to see standard_building_palette and the house_w palettes used in all the houses. Nested chunks would be good but getting all the old houses modernized is more important first.

standard_building_palette is better suited to commercial spaces, since it only has glass doors and walls. I could revamp this with domestic buildings in mind, or, I'm thinking of doing a residential version of your standard palette, then having one that is exclusively domestic furniture and loot spawns. Taking care that the two don't have symbol conflicts. That way we can use these going forward for new houses and recommend them as a best practice.

The problem with my house_w series is that they assume you are using a nest for most furniture (except bathroom and kitchen) and takes advantage of that to reuse symbols across the two palettes.

In the end, our enemy for fully standardized palettes is the lack of symbol variety.

[ymber]

standard_building_palette should only include things that are likely in a large majority of buildings so the most common terrains and furnitures have the same symbols everywhere. If you want to cut it down to fill that role then add standard domestic and commercial palettes go for it. There's not much using it right now so this would be the time.

[curstwist]

standard_building_palette should only include things that are likely in a large majority of buildings so the most common terrains and furnitures have the same symbols everywhere. If you want to cut it down to fill that role then add standard domestic and commercial palettes go for it. There's not much using it right now so this would be the time.

I'd like to add variety entries to standard_building_palette, for example

"o": [
        [ "t_window_domestic", 10 ],
        "t_window_no_curtains",
        "t_window_open",
        "t_window_no_curtains_open",
        [ "t_curtains", 5 ]
      ],

vs.

"o": "t_window",

If that works for your original intentions, I'll go ahead and adapt it.

[I-am-Erk]

Mostly just that we should try to avoid using t_grass in definitions when possible, so that any biomes that are grass-free don't show up with unexpected patches of it.

[I-am-Erk]

Should we make a custom basement for house_04 and all these houses? Not in this PR but I could probably whip something up quickly.

[curstwist]

none of the stairs are going to line up, you're call if you want to take them on. Right now they all pull from the general basement list.