Speedup move test #36664
Merged
Speedup move test #36664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
This was referenced Jan 5, 2020
|
The |
ZhilkinSerg
added a commit
that referenced
this pull request
Jan 10, 2020
kevingranade
pushed a commit
that referenced
this pull request
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
I noticed the monster speed tests were running for a long time.
Describe the solution
Don't excessively clear the map during these tests.
Testing
Tests still pass, but much much faster.
Perf says we aren't spending a significant amount of time in map manipulation anymore, the only time spent now is in monster::move and monster::can_move, but it's too tiny to go after right now.