Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite NPC love exploit #37119

Merged
merged 1 commit into from Jan 17, 2020
Merged

Fix infinite NPC love exploit #37119

merged 1 commit into from Jan 17, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 16, 2020

Summary

SUMMARY: Bugfixes "Fix infinite NPC love exploit"

Purpose of change

Fixes #36904

Describe the solution

Mirror the relation bonus from convincing an NPC to join you, with an equal penalty from asking them to leave.

Describe alternatives you've considered

N/A

Testing

Spawned NPC, got them to join, checked their trust was : 1, asked them to leave, then asked hem to join, and asked them to leave etc, a few times, checked trust it was -2.

Additional context

N/A

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Jan 16, 2020
@I-am-Erk I-am-Erk merged commit 80ce131 into CleverRaven:master Jan 17, 2020
@ghost ghost deleted the its_not_you_its_me branch January 17, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can gain infinite trust and negative infinite anger for any npc
2 participants