Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computer refactor part 2 #37299

Merged
merged 12 commits into from
Jan 24, 2020
Merged

Computer refactor part 2 #37299

merged 12 commits into from
Jan 24, 2020

Commits on Jan 24, 2020

  1. Remove unnecessary/unused members of class computer

    @Qrox
    Qrox committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    4bdee53 View commit details
    Browse the repository at this point in the history

  2. Make name and mission_id of computer private

    @Qrox
    Qrox committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    42812ba View commit details
    Browse the repository at this point in the history

  3. Make alerts a member of computer

    @Qrox
    Qrox committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    30d7ff8 View commit details
    Browse the repository at this point in the history

  4. Move initialization of next_attempt to constructor

    @Qrox
    Qrox committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    f3511d2 View commit details
    Browse the repository at this point in the history

  5. Replace shutdown_terminal with reset_terminal

    @Qrox
    Qrox committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    139e840 View commit details
    Browse the repository at this point in the history

  6. Check option enum instead of (translated) option string

    @Qrox
    Qrox committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    022d7f1 View commit details
    Browse the repository at this point in the history

  7. Migrate computer_action and computer_failure_type to use enum conversion

    @Qrox
    Qrox committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    89c8ef8 View commit details
    Browse the repository at this point in the history

  8. Use JSON (de)serialization in class computer

    @Qrox
    Qrox committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    71dcb44 View commit details
    Browse the repository at this point in the history

  9. Lift ordering restriction of computer_action and computer_failure_type

    @Qrox
    Qrox committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    e700e93 View commit details
    Browse the repository at this point in the history

  10. Remove COMPACT_OBSOLETE

    @Qrox
    Qrox committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    9f34db2 View commit details
    Browse the repository at this point in the history

  11. Fix COMPFAIL_DESTROY_DATA range

    @Qrox
    Qrox committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    a6a9ff1 View commit details
    Browse the repository at this point in the history

  12. Remove const modifiers in function declarations 

    Co-Authored-By: ZhilkinSerg <ZhilkinSerg@users.noreply.github.com>
    @Qrox @ZhilkinSerg
    Qrox and ZhilkinSerg committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    c2e215a View commit details
    Browse the repository at this point in the history