Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility of blue and brown colors #37854

Merged
merged 9 commits into from
Feb 11, 2020
Merged

Fix visibility of blue and brown colors #37854

merged 9 commits into from
Feb 11, 2020

Conversation

8street
Copy link
Contributor

@8street 8street commented Feb 9, 2020

SUMMARY: Interface "Fix visibility of blue and brown colors"

Purpose of change

As mentioned in #36722 blue-on-black color is not visible enough. It is very difficult to read the blue text near a bright text.
Changes in this PR will allow to make a color modification of #36102, in which brown-on-blue color not wisible enough.

Describe the solution

I slightly increased the brightness of blue and brown colors.
Even now, the brightness is not quite enough. But a further increase in brightness leads to incorrect color combinations.

Describe alternatives you've considered

I considered the following color options and their combinations:
Blue (20, 20, 200)
Blue (0, 0, 240)
Blue (40, 10, 200)
Blue (10, 40, 200)
Brown (102, 61, 33)

Testing

Open color manager and checking by eye

Additional context

Please open pics in new browser's tab due image compression
Before
200_2
200

After
1010220+br2
1010220+br

And further. I changed the template. The user settings whatever remain in the Cataclysm-DDA\config\base_colors.json file. I do not know how to change them on all users computers.

@ifreund ifreund added Info / User Interface Game - player communication, menus, etc. SDL: Tiles / Sound Tiles visual interface and sounds. <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON labels Feb 9, 2020
@Zireael07
Copy link
Contributor

What RGB did you finally decide on?

@8street
Copy link
Contributor Author

8street commented Feb 9, 2020

What RGB did you finally decide on?

"BROWN": [ 97, 56, 28 ],
"BLUE": [ 10, 10, 220 ],

You can see it in the "Files changed" tab at the top of the page.

@I-am-Erk I-am-Erk merged commit 3a66527 into CleverRaven:master Feb 11, 2020
@8street 8street deleted the Fix-visibility-of-blue-and-brown-colors branch February 12, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants