Fix duplicate sound display for labels sidebar #37973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Fix duplicate sound display for labels sidebar"Purpose of change
In "labels" sidebar option, remove "Sound" information display from "Needs" category. This information already exists in "Movement" where it makes more sense.
For those who don't enable "Movement" in their sidebar and still want to have information about noises, "Sound" is placed into its own category, similar to the set up for "labels-narrow" sidebar option.
Describe the solution
Move display for "Sound" out into its own section.
Describe alternatives you've considered
Not make a new category for "Sound".
Testing
Compile, load game, and activate/deactivate the affected sidebar options
Additional context
A screenshot of the "Movement" and "Needs" options currently. Note the redundant information.
