Remove obsolete random basement/house combo creation #39198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
This retires all of the code that would randomly combine a random house with a random basement in order to sometimes add houses with basements to cities.
This code was made obsolete as part of the 0.E release with the move to having all houses defined as
city_building
entries with specific house, basement and roof entries.Describe the solution
Pull the thread and nuke everything that was no longer needed, including:
Describe alternatives you've considered
None. This needs to go lest it confuse anyone doing new content creation.
Testing
Made a new world, ran around, made sure no errors triggered. Did the same with an old world.
Our previous PRs that actually retired the houses and basements bore the brunt of the issues for this--at this point, the only part of this code that could've been invoked would be the code that would place stairs, but it would only invoke for the local mapgen of a
house
OMT that had abasement
OMT underneath it, and we've migrated all of thehouse
OMTs tohouse_w_1
which has stairs down, and ourbasement
has stairs up.Folks with existing worlds with previously local mapgen'd houses may have weird stairs, but this has no bearing on that.