Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg-config build improvements #39244

Merged
merged 2 commits into from
Apr 4, 2020
Merged

pkg-config build improvements #39244

merged 2 commits into from
Apr 4, 2020

Conversation

reinerh
Copy link
Contributor

@reinerh reinerh commented Apr 4, 2020

Summary

SUMMARY: None

Purpose of change

  • the PKG_CONFIG variable was not consistently used
  • pkg-config can also be used for finding SDL2 flags

Describe the solution

  • use PKG_CONFIG where possible (there is still a place left where pkg-config is used for Mac cross building; but I'm not able to test this)
  • replace SDL2_CONFIG with PKG_CONFIG calls

@ZhilkinSerg ZhilkinSerg added Code: Build Issues regarding different builds and build environments OS: Linux Issues related to Linux operating system labels Apr 4, 2020
@ZhilkinSerg ZhilkinSerg merged commit b2f4ec6 into CleverRaven:master Apr 4, 2020
@reinerh reinerh deleted the pkgconfig branch January 6, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code: Build Issues regarding different builds and build environments OS: Linux Issues related to Linux operating system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reinerh @ZhilkinSerg