Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input polling in Linux curses build #4006

Merged
merged 2 commits into from
Nov 2, 2013

Conversation

Falconne
Copy link
Contributor

Should hopefully fix #3948

Will need someone who can reproduce the issue to test if this works.

@atomicdryad
Copy link
Contributor

Was able to make the game lag and reproduce the inertia effect (double MAPSIZE & DAYLIGHT_LEVEL + updatedb ); this fixed it. I'd imagine the effect is the same for devices that strain normally.

@axujen
Copy link
Contributor

axujen commented Oct 31, 2013

Tested on Linux ncurses build and it works as intended.

@Falconne
Copy link
Contributor Author

Falconne commented Nov 1, 2013

Regarding #3787, in theory this change should have no effect in Windows because the codepath doesn't change for SDL or wincurses. Only Linux curses handling has changed.

@kevingranade
Copy link
Member

Good point, on the basis of that I'll go ahead and pull.

@kevingranade kevingranade merged commit a421afe into CleverRaven:master Nov 2, 2013
@kevingranade
Copy link
Member

Dwarfkoala, no windows user has ever reported an overbuffering issue to me,
didn't know there was a problem there too :P
Will have to look into what needs to happen to make a similar fix on
windows.

@Falconne
Copy link
Contributor Author

Falconne commented Nov 2, 2013

I was surprise to hear about it too. The way the input polling works in the SDL and wincurses code makes it very difficult to get noticeable buffering unless the game is running seriously slow. If you're using the wincurses build, it might be worth switching to the SDL one, or vice versa, to see if it makes a difference. And if you're compiling yourself make sure to compile the RELEASE version (the Makefile defaults to DEBUG).

@Falconne Falconne deleted the Polling branch November 3, 2013 01:47
@dwarfkoala
Copy link

I just switched to SDL.

WHAT A DIFFERENCE.
I don't know why I haven't switched for this long.

On Fri, Nov 1, 2013 at 10:39 PM, Anuradha Dissanayake <
notifications@github.com> wrote:

I was surprise to hear about it too. The way the input polling works in
the SDL and wincurses code makes it very difficult to get noticeable
buffering unless the game is running seriously slow. If you're using
the wincurses build, it might be worth switching to the SDL one, or vice
versa, to see if it makes a difference. And if you're compiling yourself
make sure to compile the RELEASE version (the Makefile defaults to DEBUG).


Reply to this email directly or view it on GitHubhttps://github.com//pull/4006#issuecomment-27615291
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move buttons are queuing in the keyboard buffer
5 participants