Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow energy saber (off) to be worn at the hip #41202

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

TobalJackson
Copy link
Contributor

Summary

SUMMARY: Mods "Allow Aftershock's Energy Saber (off) to be worn at the hip"

Purpose of change

Since so many other items/weapons can be holstered or modified to use quickly, I found the energy saber's absence of this facility lacking. Being able to wear the Energy Saber (off) at the hip allows for the player to treat it like any other weapon at their disposal and holster it in a compatible piece of equipment for easy access during battle.

Describe the solution

Modified flag of energy saber (off) (adding the flag BELT_CLIP), to allow lore-friendly wearing of the saber in its off state at the belt in compatible items:
(belt of haste, belt of strength +2, Megingj..., Belt of Haste, CRIT web belt, Greater Girdle of Pockets, Belt of Weaponry, leather belt, and Lesser Girdle of Pockets)

Describe alternatives you've considered

Testing

I modified the json, loaded up my game, and was able to holster and unholster the item in a Leather Belt with no apparent ill effects.

Additional context

Modified flag of energy saber (off) to allow lore-friendly wearing of the saber in its off state at the belt in compatible items: 
(belt of haste, belt of strength +2, Megingj..., Belt of Haste, CRIT web belt, Greater Girdle of Pockets, Belt of Weaponry, leather belt, and Lesser Girdle of Pockets)
@anothersimulacrum anothersimulacrum added Mods: Aftershock Anything to do with the Aftershock mod [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Jun 9, 2020
@Rivet-the-Zombie Rivet-the-Zombie merged commit a23c282 into CleverRaven:master Jun 12, 2020
fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this pull request Jun 12, 2020
Merge pull request CleverRaven#41202 from TobalJackson/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants