Clean up overmap migration function #41241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the removed parts have been around since at least 0.E, there's not really any point in keeping them. The rural houses at least were also caught in 0.E-1, but let's keep those so as to not leave this function completely empty. This also makes some dead code - the nearby and unrelated adjacent aren't actually used anymore, but I think are worth keeping for future migrations.
anothersimulacrum
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Checking out #41237, this function took ~3.5x as long to compile as any other function!
Though, that's not the real reason, it was only 2.7 seconds.
The real reason is that this migration code is no longer necessary, and makes this into a large and very ugly function.
Describe the solution
Remove old migrations.
All of the removed parts have been around since at least 0.E, there's not really any point in keeping them.
The rural houses at least were also caught in 0.E-1, but let's keep those so as to not leave this function completely empty.
This also makes some dead code - the nearby and unrelated adjacent aren't actually used anymore, but I think are worth keeping for future migrations.
Testing
Compiles, tests pass.