Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a step to upload CBA artifacts #41257

Merged
merged 7 commits into from Jun 13, 2020

Conversation

kevingranade
Copy link
Member

Summary

SUMMARY: None

Purpose of change

It's somewhat limiting to just read the default report generated by Clang Build Analysis, so upload the analysis artifacts for later processing.

Describe the solution

Use the upload-artifact action to upload the contents of the analysis directory, which is mostly a pile of json.

Describe alternatives you've considered

Can also reconfigure CBA, but this is more flexible.

Testing

Examine the emitted artifacts.

Additional context

This will allow generation of build flamegraphs with chrome://tracing or http://jamie-wong.com/post/speedscope/

@KorGgenT KorGgenT added the Code: Build Issues regarding different builds and build environments label Jun 12, 2020
@anothersimulacrum
Copy link
Contributor

Doesn't look like it's uploading the right thing, but it is uploading something now.

@kevingranade
Copy link
Member Author

Yea the problem is I didn't capture the timing files emitted by clang... I think I have it figured out now, I have to pre-create the obj directory because while make will create it, the analysis script will not.
Something else that was confusing me was that the script was finding the obj and timing files, which was happening because it was automatically recursing to look for them. upload-artifacts on the other hand needs to know exactly where the files are.

I think this will emit some of them, but I'll want one more revision if that works to capture the traces for the test files too.

@kevingranade kevingranade merged commit daacfeb into master Jun 13, 2020
@kevingranade kevingranade deleted the kevingranade-CBA-upload-analysis-artifacts branch June 13, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants