[CR] migrate old artifacts to new #42137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
Code: Infrastructure / Style / Static Analysis
|
Does this only affect generated artifacts? What happens to JSON-defined items that use artifact properties? Right now a lot of modders depend on those since the relic mechanics aren't complete yet. |
|
this only affects generated artifacts |
|
please merge #42199 with or before this PR. if noone has any comments on the migration code it's good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Migrating legacy artifacts in saves to the new style of artifacts
Describe the solution
Any legacy artifact that is loaded into the game will now be randomly generated as a new artifact from the "cult" procgen group. The reason this is Comments Requested is that the migration looks a little hacky to me (doesn't really pass my smell test) but i also can't think of any other reasonable way to simply toss out artifacts when 0.F hits. Additionally this will be temporary and removed after 0.F Stable.
Testing
Spawn in an architect's cube. this currently uses the legacy style artifact. Save and then load. it turns into a spoon with random artifact stats.
Additional context
I left this draft because I don't want this PR merged before i get a chance to create a new style artifact that is an architect's cube.