Audit guns 22lr #42285
Merged
Audit guns 22lr #42285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Audit volume, weight, and longest side for .22 LR guns"
Purpose of change
Contribute to #41691, for adding longest_side to gun items.
Describe the solution
Added longest_side, and verified weighs and volumes to data/json/items/gun/22.json
Describe alternatives you've considered
n/a
Testing
Ran the test suite without any problems. The relevant weapons could be spawned in debug mode in-game, and had the correct properties.
Additional context
The complete data source is located here: https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit?usp=sharing
Images for the weapons involved are located here: https://drive.google.com/drive/folders/1RwRXxj5Rg8UmnPbAFz8YzOU2VT7tBWWu?usp=sharing
The image folder also contains a CSV file with measurements from ImageJ (Measurements.csv) but the same data is included in the spreadsheet.
The files involved are:
The .22 pipe rifle does not have any sources, so I set "longest_side" to 1000 mm.