Realistic mop length #42605
Merged
Realistic mop length #42605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I looked for popular wooden mops on amazon and found this one: https://www.amazon.com/Genuine-Joe-Cotton-Handle-HeadWood/dp/B001ASH5PY/ref=sr_1_33?dchild=1&keywords=mop+wooden&qid=1596220574&refinements=p_72%3A2661618011&rnid=2661617011&sr=8-33 It's length is listed as 60" or 152.4 cm. I chose to round it down to 152 cm.
|
No love for the similarly short broom? 😛 |
|
If this pull request makes it all the way through the finish line I might look at it. I was tempted to make the spear strap the only place you can store a mop on your gear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None "Changed mops' current length to a realistic one"
Purpose of change
Fixes #42529
The purpose of this minuscule change was as an attempt on my part to dip my foot in contributing to CDDA and also adjusting the length of mops to a realistic one.
Describe the solution
I added
"longest_side": "152 cm",right below the mop's volume entry.Describe alternatives you've considered
I considered not going through the process of setting up GitHub Desktop and leaving the mop as 4 inches long.
Testing
I launched my testbranch CDDA.
Started a new game with the Play Now! option.
Spawned a mop through the debug menu.
Examined the mop and it showed that it is 59 inches long and 152 cm when I switched to the metric system in the options.
Additional context
I looked for popular wooden mops on amazon and found this one:
https://www.amazon.com/Genuine-Joe-Cotton-Handle-HeadWood/dp/B001ASH5PY/ref=sr_1_33?dchild=1&keywords=mop+wooden&qid=1596220574&refinements=p_72%3A2661618011&rnid=2661617011&sr=8-33
It's length is listed as 60" or 152.4 cm. I chose to round it down to 152 cm.