Move more player functions into character #43408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Move more player functions into Character"Purpose of change
part of #34721
moves the following functions:
Describe the solution
change the scope of a selection of functions that seemed like low-hanging fruit, and then move their definitions.
Testing
Builds fine, game runs without errors.
Additional context
Character::on_hit() had some code that existed already so it just absorbed the rest of player::on_hit() because that actually had some npc and avatar logic, so i didn't feel like pulling those apart. it might be worth doing later maybe? but it looked like it was just messaging.