Make lockpicking/safecracking proficiencies functional

[I-am-Erk]

Summary

SUMMARY: Content "Makes lockpicking and safecracking proficiencies do things and be learnable."

Purpose of change

I added proficiencies for lockpicking and safecracking when I created the Devices skill, but I didn't make them do anything yet. A few redditors have noticed so I guess my clever ruse is failing... better act quick before word gets out.

Describe the solution

LOCKPICKING

• Replaces the old mechanic with a standardized normal_roll prototypic to what I have suggested in my standardized roll checks proposal.
• Devices is now the primary skill in lockpicking, but mechanics has a little role.
• Dexterity is the primary attribute in lockpicking, but per and int are also used a bit.
• If you lack basic lockpicking proficiency your skill is effectively 6 levels lower.
• If you have locksmithing proficiency your skill is effectively 4 levels higher.
• Low quality lockpicks give a small penalty and high quality give a small boost.
• Damage to your lockpicks still lowers your effectiveness.

These bonuses are mapped onto a normal_roll with a standard deviation of 2, which is (for now) compared to a randomly generated lock difficulty. In the future, lock difficulty should be defined by an attribute on the terrain/furniture you are unlocking.

Proficiency also affects the speed at which you pick a lock.

Added a debug message that displays your rolls for lockpicking.

SAFECRACKING

• Randomly fiddling with a safe dial is now much less effective based on real life likelihoods.
• Safecracking is influenced by devices, not mechanics skill.
• If you don't have the proficiency, safecracking takes 3x as long, but does grant you proficiency xp.

Describe alternatives you've considered

I was sorely tempted to improve the way we calculate these, and use a normal_roll, but I am trying to avoid adding large new features or changing balance much before Stable.

Testing

Extensive!

High failure rate with no skill, no proficiency, and average stats:

Better skill with no proficiency is less bad on your tools but still very hard:

Low skill but proficient at lockpicking is also not ideal but better than no prof:

Not screencapped: Moderate skill and having the proficiency got the lock on the first try several times.

You can learn these proficiencies through practice now.

When you do, you can advance to more complex proficiencies

I did not take screencaps of safecracking, but it works as intended: It takes a longer time without proficiency, practicing grants safecracking XP, and getting safecracking proficiency makes it much faster.

Additional context

I was going to add disarming, spotting, and setting traps to this PR, but I decided I'd rather just get this set in and work on those separately.

We really need to have lockpicking difficulty defined by the thing being picked. Currently I've left it a random number but that has to change at some point

[kevingranade]

I think pick_roll needs to be a float throughout this process, otherwise it's going to have some pretty bad rounding behavior.

[I-am-Erk]

yknow what, I'm just going to change the dang thing to use a normal_roll like I have done with traps... my code there has all the float stuff worked in.