vehicle: improve performance by removing has_part( "ROTOR" ) calls #44941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has_part( "ROTOR" ) checks every part in a vehicle to see if the part is a rotor. This is ridiculously expensive in compute time and unnecessary, because the presense of rotors is cached in vehicle::rotors which is automatically refreshed in vehicle::refresh. Replace the calls to ( has_part( "ROTOR" ) && has_part( "ROTOR_SIMPLE" ) ) with !rotors.empty() for a noticeable performance boost.
mlangsdorf
added
[C++]
| @@ -4256,7 +4256,7 @@ int vehicle::get_z_change() const | |||
|
|
|||
| bool vehicle::would_prevent_flyable( const vpart_info &vpinfo ) const | |||
| { | |||
| return is_flyable() && has_part( "ROTOR" ) && !vpinfo.has_flag( "SIMPLE_PART" ); | |||
There was a problem hiding this comment.
This should still check for the string ROTOR flag, this message shouldn't be triggering when it's a SIMPLE_ROTOR. The other change below this is potentially the same deal (though that could probably check !rotors.empty() then has_part( ROTOR ) for performance).
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/vehicle-question-spooilers-aftershock/24462/23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Performance "vehicle: improve performance by removing has_part( "ROTOR" ) calls"Purpose of change
has_part( "ROTOR" )checks every part in a vehicle to see if the part is a rotor. This is ridiculously expensive in compute time and unnecessary, because the presence of rotors is cached invehicle::rotorswhich is automatically refreshed invehicle::refresh().Profiling was showing that 6% of overall compute time was spent
has_rotor( "ROTOR" )calls.Describe the solution
Replace the calls to
( has_part( "ROTOR" ) && has_part( "ROTOR_SIMPLE" ) )with!rotors.empty()for a noticeable performance boost.Describe alternatives you've considered
More caching could be done in
vehicle::check_falling_or_floating()but I think this is the big pay-off.Testing
Ran the unit tests successfully.