New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement proficiencies being used for books #45128
implement proficiencies being used for books #45128
Conversation
We'll also need to display proficiency bonus on the book item |
8bf842d
to
d9bf196
Compare
So I think the only thing this needs to merge is a UI line on the book items themselves saying what proficiency bonunses they offer, and possibly for the crafting menu to mention either what the bonuses from books are, or at least that there are bonuses from books being applied. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure if the ranged_balance thing is a problem, or just a false positive on a statistical test. See #46256.
@@ -371,6 +386,7 @@ | |||
"skill": "fabrication", | |||
"max_level": 2, | |||
"intelligence": 5, | |||
"proficiencies": [ { "proficiency": "prof_carpentry_basic", "time_factor": 0.4, "fail_factor": 0.8, "include_prereqs": true }, { "proficiency": "prof_plumbing", "time_factor": 0.5, "fail_factor": 0.8, "include_prereqs": true } ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"proficiencies": [ { "proficiency": "prof_carpentry_basic", "time_factor": 0.4, "fail_factor": 0.8, "include_prereqs": true }, { "proficiency": "prof_plumbing", "time_factor": 0.5, "fail_factor": 0.8, "include_prereqs": true } ], | |
"proficiencies": [ | |
{ "proficiency": "prof_carpentry_basic", "time_factor": 0.4, "fail_factor": 0.8, "include_prereqs": true }, | |
{ "proficiency": "prof_plumbing", "time_factor": 0.5, "fail_factor": 0.8, "include_prereqs": true } | |
], |
@@ -389,6 +405,7 @@ | |||
"skill": "fabrication", | |||
"required_level": 5, | |||
"max_level": 8, | |||
"proficiencies": [ { "proficiency": "prof_carpentry_basic", "time_factor": 0.7, "fail_factor": 0.3, "include_prereqs": true }, { "proficiency": "prof_plumbing", "time_factor": 0.85, "fail_factor": 0.5, "include_prereqs": true } ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"proficiencies": [ { "proficiency": "prof_carpentry_basic", "time_factor": 0.7, "fail_factor": 0.3, "include_prereqs": true }, { "proficiency": "prof_plumbing", "time_factor": 0.85, "fail_factor": 0.5, "include_prereqs": true } ], | |
"proficiencies": [ | |
{ "proficiency": "prof_carpentry_basic", "time_factor": 0.7, "fail_factor": 0.3, "include_prereqs": true }, | |
{ "proficiency": "prof_plumbing", "time_factor": 0.85, "fail_factor": 0.5, "include_prereqs": true } | |
], |
@@ -425,6 +443,7 @@ | |||
"color": "green", | |||
"skill": "fabrication", | |||
"max_level": 3, | |||
"proficiencies": [ { "proficiency": "prof_carpentry_basic", "time_factor": 0.5, "fail_factor": 0.4, "include_prereqs": true }, { "proficiency": "prof_plumbing", "time_factor": 0.5, "fail_factor": 0.6, "include_prereqs": true } ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"proficiencies": [ { "proficiency": "prof_carpentry_basic", "time_factor": 0.5, "fail_factor": 0.4, "include_prereqs": true }, { "proficiency": "prof_plumbing", "time_factor": 0.5, "fail_factor": 0.6, "include_prereqs": true } ], | |
"proficiencies": [ | |
{ "proficiency": "prof_carpentry_basic", "time_factor": 0.5, "fail_factor": 0.4, "include_prereqs": true }, | |
{ "proficiency": "prof_plumbing", "time_factor": 0.5, "fail_factor": 0.6, "include_prereqs": true } | |
], |
Summary
SUMMARY: Features "implement proficiencies being used for books"
Purpose of change
Resolves #44680
Describe the solution
as requested by @I-am-Erk , proficiency fail and time modifiers will now also be modified by the books available to you in your crafting inventory. this adds a struct to hold the data, loading that data into a vector in an islot_book, a new class as a container for the vector with methods to do all the calculations behind the scenes, and methods in inventory in order to use crafting_inventory() easily.
Testing
still needs json and also testing. it compiles.