Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pillowcases #46067

Closed
wants to merge 3 commits into from
Closed

Conversation

BigHatRince
Copy link

@BigHatRince BigHatRince commented Dec 16, 2020

Added pillowcases and made pillows spawn inside them

Summary

SUMMARY: Features "Added Pillowcase item and made pillows spawn with them."

Purpose of change

Pillowcases did not exist and pillows spawned without pillowcases. This made little sense as realistically pillowcases do exist and typically contain pillows. Pillowcases would also be useful in a zombie apocalypse as easily found sacks.

Describe the solution

Created a pillowcase item, made pillows spawn contained within pillowcases.

Describe alternatives you've considered

Not Applicable

Testing

Generated a world to see if pillows would spawn contained by pillowcases, they did.

Additional context

None.

Added pillowcases and made pillows spawn inside them
@anothersimulacrum anothersimulacrum added the [JSON] Changes (can be) made in JSON label Dec 16, 2020
Copy link
Contributor

@anothersimulacrum anothersimulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add SUMMARY: before Features to have a valid summary line.

data/json/items/generic.json Outdated Show resolved Hide resolved
BigHatRince and others added 2 commits December 15, 2020 17:21
Co-authored-by: anothersimulacrum <anothersimulacrum@gmail.com>
@Qrox
Copy link
Contributor

Qrox commented Dec 16, 2020

Maybe body pillows should also spawn inside body pillow cases? (Ideally a separate item that retains the anime character.)

"price_postapoc": 2,
"to_hit": -5,
"material": [ "cotton" ],
"pocket_data": [ { "pocket_type": "CONTAINER", "max_contains_volume": "15 L", "max_contains_weight": "15 kg", "moves": 400 } ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pillows are currently ~1L so 15L seems too large for a pillow case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pillows are soft and can be squashed into a smaller space, when the foam/stuffing is expanded instead of contracted it's much larger.
Pillows should probably be at least 3L however.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I do agree pillows should be 3L, but this is for pillow cases, A pillowcase all scrunched up is easily 1L.
15L is less than you'd think, only about 4 gallons.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally I made them the same size as canvas sacks (15L) because I thought they seemed about the right size, for additional usefulness, and because it's my first time doing this.

@blot-runner
Copy link
Contributor

Good job! It's always important to be able to keep your pillow clean, especially in the middle of zombie apocalypse. Points for realism, too.
Now, if only we had some bedsheets (and probably duvet covers, at least for down-filled blankets)...

@stale
Copy link

stale bot commented Jan 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jan 17, 2021
@Night-Pryanik
Copy link
Contributor

@BigHatRince could you please resolve conflicts?

@stale stale bot removed the stale Closed for lack of activity, but still valid. label Feb 3, 2021
@Qrox
Copy link
Contributor

Qrox commented Feb 4, 2021

I think the changes in this PR has already been merged in #46068, so unless I'm missing something this PR can be closed. (The other suggestions can be implemented in a new PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants