Make acetylene torch cut metal walls.

[NeviNovat]

Summary

SUMMARY: Features "Make acetylene torch cut metal walls."

Purpose of change

Acetylene torches can cut metal doors but can't cut metal walls, this would be fine if the metal wall was supposed to be something really hard to cut or destroy but a pickaxe can be used to "mine" it and remove it, so this leads me to believe that the wall is not that heavy duty. Also the acetylene torch in-game is perfectly capable to cut metal as described in the in-game description of it: "... In addition to its metalworking uses, you can activate it in order to destroy metal barriers.".

Describe the solution

Add the metal wall (t_wall_metal) to the list of terrain that is checked when activating an acetylene torch. Also add the metal wall (t_wall_metal) to the list that dictates how much charge and time a metal door requires to be cut.
The remaining components can be 2 or 3 steel plating and from 12 to 20 chunks of metal, to construct a metal wall you need a total of 4 steel plating and a welding tool, and 1 steel plating requires 8 steel lumps of steel (1 lump = 4 chunks of steel) so in total the maximum amount of plates you can get back is ~3.6 steel plating.

Describe alternatives you've considered

Make 2 different metal walls, one that can be cut and is used for silos or other buildings and one that can't be cut and is maybe used in bunkers or labs.

Testing

I have found a silo and spawned myself an acetylene torch with fuel and activated it, selected a wall and inspected the result.

Additional context

The time it requires is 15 seconds and 60 oxyacetylene charges. This is the same as the metal door. I will open an issue on this because this seems very quick (the issue is: Ridiculously low amounts of time spent cutting with an acetylene torch. #46257). Only the heating of the metal requires 10 sec at least ... I think, I don't have experience here but this is clearly to fast.

[Shodan14]

Presumably for the door you'd just cut the hinges and/or the bolt. Sounds like it'd be exponentially more work for a metal wall :/

[NeviNovat]

Presumably for the door you'd just cut the hinges and/or the bolt. Sounds like it'd be exponentially more work for a metal wall :/

You are correct, but for a silo wall, it would be easy, maybe a bit time consuming (also silos have doors...at least the ones I've seen, the ones in game don't). now that I look at it a lot more, there is a need for at least 2 (maybe even 3?) different types of metal wall one made of thicker metal then the other (one made with hard plating the other with normal steel plating for example) this way you need a bigger non-portable torch for the other, one that is not in game at the moment.

[emptytriangle]

what about making a new thin sheet metal wall that can be penetrated with the acetylene torch and changing silos to use this sheet metal wall? Then existing impenetrable structures will remain impenetrable. Other structures which need to change from metal wall to sheet metal wall can be updated in future PRs

[NeviNovat]

what about making a new thin sheet metal wall that can be penetrated with the acetylene torch and changing silos to use this sheet metal wall? Then existing impenetrable structures will remain impenetrable. Other structures which need to change from metal wall to sheet metal wall can be updated in future PRs

Maybe the best solution would be making 3 walls:

• sheet metal wall , can be bashed in but its quicker to cut with acetylene, or other power tools. ( for example: silo walls )
• metal wall, can't be bashed requires tools like acetylene torch or probably other tools can cut it as well. ( for example: city banks vaults, prisons maybe )
• hard metal wall (made out of hard plating as opposed to normal steel plating), can't be bashed , can't be penetrated with normal acetylene torch or normal tool ,maybe with industrial ones or other more advanced power tools/ explosives. ( for example: lab entrance walls, nuclear bunkers, or when you want to contain something really dangerous with 100% certainty )

The current wall is made out of steel plating that can be cut with acetylene torch ( or at least we are debating that over in another PR at the moment, see #46257 for that part ) so this PR still stands as is.

As for having impenetrable structures, I don't think that's correct maybe you mean you want existing structures to have the same accessibility as when you couldn't just use an acetylene torch on them? Because you can "mine" the metal wall with a pickaxe ( or a jackhammer if I remember correctly ).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[NeviNovat]

After more conversations and time from the initial start of this PR it seams apparent that the actual issue is adding more metal wall types since there are buildings that need them. Currently I am only aware of 2 types of metal wall, neither actually are fit for being a silo wall or maybe a wall of a metal shack.

That being said the metal wall that we are seeing here is a wall that could have concrete backing since its the same wall that appears in bank vaults and other sites. The concrete backing would make cutting the wall with an acetylene torch a time and resource consuming task, as mentioned in (Ridiculously low amounts of time spent cutting with an acetylene torch.) #46257. It would also not fully remove the wall since the concrete would be still there.

On the other hand, we can jackhammer ( or pickaxe, but that seams to be an oversight not a feature, ) the wall already. So its not like this PR would make previously inaccessible areas accessible, it would only make them more then they are already.

And that's why I didn't make the last change sooner, I just didn't know how to approach it. I still think that acetylene torches should be able to cut the current version of the metal wall.

[int-ua]

Looks like you also have to add t_scrap_wall_halfway in mapdata.h

[NeviNovat]

Done. For me it worked with no errors.