Fix ammo proportional/relative member assignment #47567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#43144 will fix this (though after 0.F) |
|
yeah i'd much rather we fix this correctly instead of backpedaling. i'd like us to move toward using mandatory and optional rather than assign, because the default values are then much more visible. i know that assign also has the functionality where there's an acceptable range of values which optional and mandatory doesn't have, but the part of manda |
|
Closing blocker now. Will be fixed properly later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix ammo proportional/relative member assignment"
Purpose of change
Fixes #47565.
Describe the solution
Revert to using
assigninislot_ammo::load.Testing
Checked in game and ammo properties were correctly assigned according to proportional/relative values.
Additional context
We might want to check if a proportional or relative field is unused, but a fix is not straighfoward because these fields are accessed in different places and it might not be easy to check which are unvisited.