Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Magiclysm) Fix spell-made gear not fitting their mutant casters #48221

Merged
merged 4 commits into from Jul 6, 2021
Merged

(Magiclysm) Fix spell-made gear not fitting their mutant casters #48221

merged 4 commits into from Jul 6, 2021

Conversation

SariusSkelrets
Copy link
Contributor

@SariusSkelrets SariusSkelrets commented Mar 25, 2021

Summary

Mods "Fix Ice Gliders unable to be equipped by mutants (and fix spiritual armor too)"

Purpose of change

Hooves, leg tentacles and similar mutations prevent wearing ice gliders. This change will make the player able to equip their custom-made spell-created gliders

Describe the solution

add OVERSIZE and VARSIZE to them

Describe alternatives you've considered

Not letting mutants make items they can wear thus making the spell useless for them

Testing

  1. Spawn a characther with leg tentacles
  2. Cast Glide on Ice
  3. Wield the gliders you can't equip
  4. Add the tags
  5. Cast the spell again
  6. Enjoy your (n)ice shoes

Additional context

Edit: A reddit post mentionned that spiritual armor wasn't able to fit mutants. I found that the spell copied a mutant-unfriendly armor so I added an armor with mutant-allowing flag and a helmet (represented by head covering) to the spell

I didn't found other problematic spell-created gear. If you find some, tell me and I'll fix them too.

@BrettDong BrettDong added [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod labels Mar 26, 2021
@SariusSkelrets SariusSkelrets changed the title (Magiclysm) Fix Ice Gliders not fitting mutants (Magiclysm) Fix spell-made gear not fitting their mutant casters Mar 27, 2021
@actual-nh actual-nh added the <Bugfix> This is a fix for a bug (or closes open issue) label Apr 12, 2021
Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com>
@actual-nh
Copy link
Contributor

I think the PR validator's problem is that it wants actual double quotes and not two single quotes.

@Maleclypse Maleclypse changed the base branch from master to 0.F-dev June 9, 2021 03:56
@ZhilkinSerg ZhilkinSerg force-pushed the 0.F-dev branch 3 times, most recently from ac1984a to c8f13cf Compare June 14, 2021 15:06
@ZhilkinSerg ZhilkinSerg changed the base branch from 0.F-dev to master July 4, 2021 18:02
@ZhilkinSerg ZhilkinSerg merged commit 9a09044 into CleverRaven:master Jul 6, 2021
@SariusSkelrets SariusSkelrets deleted the Tailored_SpellGear branch July 6, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants