Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new worn unarmed weapons #49118

Closed
wants to merge 5 commits into from
Closed

Conversation

Saelfen
Copy link
Contributor

@Saelfen Saelfen commented Jun 1, 2021

Summary

Content "Add Impact and Skewer Knuckles"

Purpose of change

Add content to unarmed combat caused by the void left over by #48503. By this point, only 4 unarmed weapons exist in the game. I saw this as an opportunity to use infrastructure added in #41209 for top layer gloves to be used as unarmed weapons to give them a useful niche of their own.

Describe the solution

Create Impact Knuckles and Skewer Knuckles with stats based relative to existing items.
Impact Knuckles has 12 bash (same damage as a pipe), and Skewer Knuckles with 10 pierce ( same damage as a steel sewing awl). From a weapons damage perspective, they are relatively weak combat stat-wise, Impact knuckles being barely stronger than a cudgel which is craftable seconds after starting the game, and Skewer Knuckles being only slightly stronger than a steak knife. This is intentional since unarmed weapons should not be stronger than armed weapons due to leverage and reach.

Describe alternatives you've considered

Not make them at all

Testing

Impact Knuckles:
image

Skewer Knuckles:
image

Additional context

Additional changes in this PR:
Moved previously unarmed weapons out of the unarmed json file since they are no longer unarmed weapons.
Removed Bolt cutters from studded gloves since studs do not need bolt cutters to make, only a hammer.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This recipe should be handled by their common tool quality of bolt turning, not specific items that happen to have bolt turning.

data/json/recipes/armor/hands.json Outdated Show resolved Hide resolved
data/json/recipes/armor/hands.json Outdated Show resolved Hide resolved
@actual-nh actual-nh added 0.F Content Freeze Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Jun 1, 2021
Saelfen and others added 2 commits May 31, 2021 21:49
Co-authored-by: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>
Co-authored-by: LaVeyanFiend <51099123+LaVeyanFiend@users.noreply.github.com>
@Saelfen
Copy link
Contributor Author

Saelfen commented Jun 1, 2021

Changes as per code review:
Moved cestus from swords and blades to bludgeon
Added mandatory double spacing between sentences
take into consideration mass conversion and now only use 1 lump of steel per item
Reduce time to craft for both weapons from 8 hours to 4 hours
Reduce mass of both weapons; about half a lb per hand for impact knuckles sounds reasonable (about the weight of a hammer on each hand), and a quarter of a lb for each hand for skewer knuckles.
Reduce volume of both weapons; 300ml for both down from 500ml. It made no sense for them to be twice the volume of leather gloves (250ml)

Updated original post with new screenshots

@Salty-Panda
Copy link
Contributor

You will need to call out in #dev-help to have a dev run tests for you

@Saelfen
Copy link
Contributor Author

Saelfen commented Jun 1, 2021

You will need to call out in #dev-help to have a dev run tests for you

Did you mean unit tests? I ran them locally and they all pass below:
image

@Salty-Panda
Copy link
Contributor

Those on site

@Saelfen
Copy link
Contributor Author

Saelfen commented Jun 1, 2021

Looks to me all tests are triggered automatically on commit since they're running now

@esotericist
Copy link
Contributor

Looks to me all tests are triggered automatically on commit since they're running now

salty panda meant these
Screenshot_20210601-065235

for security reasons, github requires new contributors to be authorized to run tests that might be able to be malicious

fortunately, I have the authorization to hit that button for you

@Saelfen
Copy link
Contributor Author

Saelfen commented Jul 13, 2021

Re-PR'd in #49914 which also addresses merge conflicts and the move towards the new armor portion format

@Saelfen Saelfen closed this Jul 13, 2021
@Saelfen Saelfen deleted the unarmed-weapons branch July 19, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants