Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix welding requirement on some recipes #49538

Merged
merged 4 commits into from Jul 7, 2021

Conversation

Hirmuolio
Copy link
Contributor

Summary

Bugfixes "Fix welding requirement on some recipes"

Purpose of change

Some recipes had nonfunctional welding requirements.
These recipes required welding tool instead of welding charges. They did not consume any charges (you could even do them with empty welder).
Some of them also did not require glare protection.

Describe the solution

Replace welding tool requirements with "using": [ [ "welding_standard", 1] ],

Describe alternatives you've considered

Testing

Craft the recipe. It consumes welding charges.

Additional context

The welding tools still have the "WELD" attribute. This does nothing for crafting or tool use.

The "WELD" quality is still used in one place in c++ for some vehicle welding rig related check here https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/activity_item_handling.cpp#L922. Not sure if that check is even necessary. It seems like you could just fetch the welding rig without doing this check.

Those pipe shotgun recipes are weird. The double variant is faster to make than single variant.

@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling and removed [C++] Changes (can be) made in C++. Previously named `Code` labels Jul 3, 2021
@kevingranade
Copy link
Member

I'm also backporting this to 0.F

@kevingranade kevingranade merged commit bb39692 into CleverRaven:master Jul 7, 2021
@Hirmuolio Hirmuolio deleted the weld branch July 31, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants