Fix welding requirement on some recipes #49538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix welding requirement on some recipes"
Purpose of change
Some recipes had nonfunctional welding requirements.
These recipes required welding tool instead of welding charges. They did not consume any charges (you could even do them with empty welder).
Some of them also did not require glare protection.
Describe the solution
Replace welding tool requirements with
"using": [ [ "welding_standard", 1] ],
Describe alternatives you've considered
Testing
Craft the recipe. It consumes welding charges.
Additional context
The welding tools still have the
"WELD"
attribute. This does nothing for crafting or tool use.The
"WELD"
quality is still used in one place in c++ for some vehicle welding rig related check here https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/activity_item_handling.cpp#L922. Not sure if that check is even necessary. It seems like you could just fetch the welding rig without doing this check.Those pipe shotgun recipes are weird. The double variant is faster to make than single variant.