Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebalance guitars (and similar instruments) as melee weapons. #50034

Merged
merged 5 commits into from Aug 1, 2021

Conversation

Aerin-of-the-Toast
Copy link
Contributor

@Aerin-of-the-Toast Aerin-of-the-Toast commented Jul 18, 2021

Summary

Balance "Make the apocalypse a bit more metal by rebalancing several instruments as melee weapons"

Purpose of change

Guitars are heavy, break pretty easily when slammed into things, and are quite unwieldy as weapons, so it was bizarre that their stats before did a very paltry amount of bashing damage (less than a pipe or cudgel despite being way larger) and had +2 to hit.

Describe the solution

Jacked up the damages of guitars by quite a lot; electric guitar (26 bash) and acoustic guitar (18 bash) damages were suggested by mlangsdorf and damages for other guitar-ish weapons (violin, banjo, ukulele) were also increased. To-hit nerfed across the board from +2 to -1 in accordance with the game balance doc. All were given FRAGILE_MELEE because if you've ever watched a video of a concert where they smash guitars on the ground, they only last a couple of swings.

EDIT: Fixed the to-hit of the golden fiddle as well, since I forgot to do that the first time around, and made sure the to-hit followed the new formatting. Didn't adjust the damage of the golden fiddle though, I'm not entirely sure how much damage a solid-gold violin would even do, if you could even swing it...

Describe alternatives you've considered

Embracing the spirit of heavy metal and giving them outright battle axe stats. This is a joke. I'm also half tempted to make the acoustic and electric guitars valid Fior Di Battaglia weapons, but that might be too absurd.

Testing

Tested with debug, stats were adjusted correctly.

Additional context

DPS still is pitifully low for all of them due to the very slow speed and bad accuracy, all below the DPS of a pipe, but at least now when you channel your inner Jack Black and start hitting zombies with them they'll at least do good damage when you do hit.

@actual-nh actual-nh added <Bugfix> This is a fix for a bug (or closes open issue) Game: Balance Balancing of (existing) in-game features. Items / Item Actions / Item Qualities Items and how they work and interact Melee Melee weapons, tactics, techniques, reach attack [JSON] Changes (can be) made in JSON labels Jul 18, 2021
Copy link
Contributor

@anothersimulacrum anothersimulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the to-hit to use the new format. I chose values based on what I thought was correct, they may not be what you would put.
I get different values than -1 (-2), probably because of a different balance value.

@@ -10,8 +10,9 @@
"longest_side": "72 cm",
"price": 7500,
"price_postapoc": 500,
"to_hit": 2,
"bashing": 7,
"to_hit": -1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"to_hit": -1,
"to_hit": { "grip": "none", "length": "short", "surface": "any", "balance": "clumsy" },

@@ -159,8 +160,9 @@
"longest_side": "58 cm",
"price": 7500,
"price_postapoc": 250,
"to_hit": 2,
"bashing": 5,
"to_hit": -1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"to_hit": -1,
"to_hit": { "grip": "none", "length": "short", "surface": "any", "balance": "clumsy" },

@@ -189,8 +191,9 @@
"longest_side": "60 cm",
"price": 7500,
"price_postapoc": 600,
"to_hit": 2,
"bashing": 5,
"to_hit": -1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"to_hit": -1,
"to_hit": { "grip": "none", "length": "short", "surface": "any", "balance": "clumsy" },

data/json/items/tool/musical_instruments.json Outdated Show resolved Hide resolved
data/json/items/tool/musical_instruments.json Outdated Show resolved Hide resolved
Aerin-of-the-Toast and others added 2 commits July 18, 2021 18:00
Co-authored-by: anothersimulacrum <anothersimulacrum@gmail.com>
Co-authored-by: anothersimulacrum <anothersimulacrum@gmail.com>
@@ -308,7 +311,7 @@
"category": "tools",
"weight": "3750 g",
"color": "red",
"to_hit": 2,
"to_hit": { "grip": "none", "length": "short", "surface": "any", "balance": "clumsy" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you committed the wrong one.

Suggested change
"to_hit": { "grip": "none", "length": "short", "surface": "any", "balance": "clumsy" },
"to_hit": { "grip": "none", "length": "long", "surface": "any", "balance": "clumsy" },

@pehamm
Copy link
Contributor

pehamm commented Jul 19, 2021

Shouldn't balance be uneven rather than clumsy? I just grabbed two of my guitars and the weight distribution absolutely allows for swinging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Game: Balance Balancing of (existing) in-game features. Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Melee Melee weapons, tactics, techniques, reach attack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants