New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some assorted mutant bits #50221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Enhancement / Feature>
New features, or enhancements on existing
[JSON]
Changes (can be) made in JSON
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Items: Food / Vitamins
Comestibles and drinks
Monsters
Monsters both friendly and unfriendly.
labels
Jul 25, 2021
Offal adjustments
Also no pancreas for you
Fris0uman
reviewed
Jul 25, 2021
Similar solution as #50228 |
actual-nh
reviewed
Jul 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting!
Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com>
Not inheriting the badness of mutant stuff is a problem, but that's why we have toxins
satheon49
pushed a commit
to satheon49/Cataclysm-DDA
that referenced
this pull request
Aug 14, 2021
* Mutant brains * Mutant lungs * Mutant liver Offal adjustments * Mutant kidneys Also no pancreas for you * Organ meats are good for you, m'kay? Not inheriting the badness of mutant stuff is a problem, but that's why we have toxins Co-authored-by: actual-nh <74678550+actual-nh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
<Enhancement / Feature>
New features, or enhancements on existing
Items: Food / Vitamins
Comestibles and drinks
[JSON]
Changes (can be) made in JSON
Monsters
Monsters both friendly and unfriendly.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Add mutated organs to more animals"
Purpose of change
Unlike mutant bugs, mutated vertebrates weirdly drop completely safe and unmutated organs. This PR fixes that glaring oversight and adds some disgusting snippets to make players think a bit more about chomping down on that rattlesnake.
Describe the solution
Added mutated brains, kidneys, livers and lungs to vertebrates, as well as cooked equivalents. Each comes with a handful of description snippets, and I updated all normal recipes to take the new variants as well. While I was here I streamlined the recipes a bit by moving some flag removals into the recipe def instead of the resulting item.
Describe alternatives you've considered
Do something for humanoid mutants, but I kind of ran out of steam and they will be the focus of an upcoming PR anyway.
Testing
Butchering a critter yields the appropriate variants, cooking tracks toxins and bad taste properly.
Additional context
The toxin content is a bit arbitrary, I went with relatively high for the brain/liver/kidney (fatty accumulation and detoxifying organs, respectively) and a low value to lungs (though with how calorie-poor they are I think it could be a tad lower still).
There is a bug where snippets with ids lose their uniqueness when stacked, I'll have to check if that's reported already.