Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DinoMod] juvenile dino bugfixes #50377

Merged
merged 5 commits into from Aug 3, 2021
Merged

[DinoMod] juvenile dino bugfixes #50377

merged 5 commits into from Aug 3, 2021

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Jul 31, 2021

Summary

Mods "Juvenile dino bugfixes"

Purpose of change

Realism, balance, make maintaining easier, tidier code

Describe the solution

Reorder juvenile page to match the rest. Sauropod juveniles are reworked to not create GUILT, less line duplication, have weaker special attacks, have weaker stats but not useless, clearer descriptions

Copies new zombie dino fixes to include the new zombie amargasaurus juvenile this depends on

Describe alternatives you've considered

Try to fix #47145 but that appears to be a larger problem in vanilla

Testing

Game loads no errors, fixes work as expected

Additional context

"Not The Momma!" -Dinosaurs

@LyleSY LyleSY added <Bugfix> This is a fix for a bug (or closes open issue) Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. labels Jul 31, 2021
@actual-nh
Copy link
Contributor

A related problem - hatching mosasaurus are currently described the same way as any other red-and-white hatchling... despite having the AQUATIC (and SWIMS) flag(s), which should readily enable distinguishing them.

@LyleSY LyleSY added this to Doing in DinoMod via automation Aug 1, 2021
@LyleSY
Copy link
Contributor Author

LyleSY commented Aug 1, 2021

Agreed, addressing that in another PR

@LyleSY LyleSY marked this pull request as ready for review August 3, 2021 01:20
@ZhilkinSerg ZhilkinSerg merged commit 6827cfc into master Aug 3, 2021
DinoMod automation moved this from Doing to Done Aug 3, 2021
@LyleSY LyleSY deleted the LyleSY-patch-7 branch August 7, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Monsters Monsters both friendly and unfriendly.
Projects
DinoMod
  
Done
Development

Successfully merging this pull request may close these issues.

Friendly baby monsters disappear when they grow up
3 participants