Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #50405

Closed
wants to merge 1 commit into from
Closed

Fix unit tests #50405

wants to merge 1 commit into from

Conversation

Saelfen
Copy link
Contributor

@Saelfen Saelfen commented Aug 2, 2021

Summary

Bugfixes "Fix unit tests"

Purpose of change

Fix unit test failures caused by #50403 and #49856

Describe the solution

Fix unit tests

Describe alternatives you've considered

none

Testing

image

@BrettDong
Copy link
Member

See #50390 for some discussion on the failing DPS tests.

@anothersimulacrum
Copy link
Member

BrettDong#8 plus that should fix both.

@actual-nh actual-nh added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` labels Aug 2, 2021
@BrettDong
Copy link
Member

Superseded by #50390.

@Saelfen Saelfen closed this Aug 2, 2021
@Saelfen Saelfen deleted the Nausea-test branch August 2, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants