Adding proper meth recipe #50511
Merged
Adding proper meth recipe #50511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two new chemical items: red phosporous, pure iodine (not potassium iodine) and acetic anhydride. Added these to the loot pool of the chemical lab and meth lab truck. Also, removed old items from meth lab truck and basement. Added a new recipe for the making of high-grade meth, which requires a long time, chemical proficiency and lots of chemicals. The high grade meth has slightly better stats than the low grade one. Also added the other materials needed for it on the loot pool of the chemistry lab, since it makes sense and they were already pretty scarce. Lastly, planning on adding heroin synthesis from morphine using the last added item: acetic anhydride, but will probably do it tomorrow, since this took me much longer than I was expecting.
actual-nh
added
<Enhancement / Feature>
|
I can't judge your chemistry but the json looked good when I looked through. I'm going to edit your PR Summary for you because it's complicated the first time and it'll make more sense once you see what it should look like. |
|
https://dev.narc.ro/cataclysm/format.html can be used to fix the json style errors. |
|
Yeah, it looked fine on notepad++, but something happened when transferring it back to github, will use it next time though. |
Qrox
reviewed
Aug 6, 2021
Adding missing pontuaction Co-authored-by: chaohedgehogs <46550455+chaohedgehogs@users.noreply.github.com>
Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/realistic-chemistry-recipes/26802/8 |
|
It's about time that we reach something that is 99.1% pure |
Workflow was asking me to add two spaces after the period, for some reason, so I did.
data/json/items/comestibles/med.json
Outdated
| @@ -2025,5 +2025,30 @@ | |||
| "addiction_type": "cocaine", | |||
| "flags": [ "NO_INGEST", "WATER_DISSOLVE" ], | |||
| "use_action": { "type": "heal", "bleed": 20, "move_cost": 100, "effects": [ { "id": "pkill1", "duration": 720 } ] } | |||
| }, | |||
| { | |||
| "id": "pure_meth", | |||
There was a problem hiding this comment.
Please move this next to the existing meth item, we don't usually enforce any particular ordering, but if there are variants of the same thing they should be next to each other.
There was a problem hiding this comment.
Done. Also, was this the reason the workflow was failing? I checked the script but the error seemed kinda random.
moving new meth next to old meth in the file.
AMurkin
added a commit
to AMurkin/Cataclysm-DDA
that referenced
this pull request
Sep 5, 2021
AMurkin
added a commit
to AMurkin/Cataclysm-DDA
that referenced
this pull request
Sep 5, 2021
Nabo92
added a commit
to Nabo92/Cataclysm-DDA
that referenced
this pull request
Sep 5, 2021
following up on PR CleverRaven#50511, added proper heroin recipe with the item added on previous PR. Also correcting typo on red phosphorous, correcting weight of acetic anhydride to match it's density. Also deleted the item match head powder and changed all the recipes associated to it to the proper element
Venera3
pushed a commit
to Venera3/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2021
* Ading proper meth recipe Added two new chemical items: red phosporous, pure iodine (not potassium iodine) and acetic anhydride. Added these to the loot pool of the chemical lab and meth lab truck. Also, removed old items from meth lab truck and basement. Added a new recipe for the making of high-grade meth, which requires a long time, chemical proficiency and lots of chemicals. The high grade meth has slightly better stats than the low grade one. Also added the other materials needed for it on the loot pool of the chemistry lab, since it makes sense and they were already pretty scarce. Lastly, planning on adding heroin synthesis from morphine using the last added item: acetic anhydride, but will probably do it tomorrow, since this took me much longer than I was expecting. * linting linting previous PR * Update data/json/items/comestibles/med.json Adding missing pontuaction Co-authored-by: chaohedgehogs <46550455+chaohedgehogs@users.noreply.github.com> * Update data/json/items/chemicals_and_resources.json Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com> * Update science_and_tech.json * adding spaces Workflow was asking me to add two spaces after the period, for some reason, so I did. * changing item order in file moving new meth next to old meth in the file. Co-authored-by: chaohedgehogs <46550455+chaohedgehogs@users.noreply.github.com> Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>
Venera3
pushed a commit
to Venera3/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2021
I-am-Erk
pushed a commit
that referenced
this pull request
Dec 15, 2021
* Small drug synthesis rework following up on PR #50511, added proper heroin recipe with the item added on previous PR. Also correcting typo on red phosphorous, correcting weight of acetic anhydride to match it's density. Also deleted the item match head powder and changed all the recipes associated to it to the proper element * further fixing of typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "New chemical ingredients and adjust meth recipe"
Added chemical recipe for making high-grade meth, the high-grade meth the two chemical items needed that weren't in game. Added these and the other chemicals needed for the recipe to the loot pool of the chemistry, mobile and basement lab. Also added acetic anhydride because I intend on making a recipe for the synthesis of heroin. Also, removed old items from meth lab truck and basement.
The new high grade meth has slightly better stats than the low grade one. The downside is that it takes a lot of chemicals, chemistry skill and it takes 6 hours to complete (should maybe be a bit longer, but I guess a skilled chemist could do it in this time).
Purpose of change
I was always bothered by the fact that the game only had low-grade methamphetamine, and since this is a pretty easy synthesis IRL, I added the recipe for it.
Describe the solution
The current recipe for making the low quality meth is absolutely unrealistic, I could maybe add another recipe with the same ingredients and lower skill, but I guess it wouldn't make sense for the player to make it, so I'd just remove it from the game entirely. I could easily do it in another PR (along with the heroin recipe) if this one is well recieved (it's mt first time, be gentle with me).
Describe alternatives you've considered
Just removing the recipe for low quality meth, but that would be lazy.
Testing
Got into a debug world, spawned the new items, tested their weights, spawned a meth truck (loot pool was indeed altered), and made the new meth. Seems to be working alright. Didn't go far enough as to get into a lab or meth basement and check if the items were there, but I guess it worked, since they spawned on the mobile meth lab.
Additional context
I didn't add the solvents necessary for it in the mobile and basement labs, because that'd be too easy for the player, the way it's implemented means that the player HAS to explore the lab, which I guess gives more reason for a player to go there.
Some additional details concerning realism: the batch savings time is really high because that's how it usually works in real life, making a chemical is a lot of work and it doesn't matter much if you make 1g or 10g, the amount of time is roughly the same.
Hope this is my first of many PRs of adding more chemical stuff to the game, still intend on implementing the heroin and kevlar synthesis and the obtaining of red phosphorous from matches.
Also, if someone has more ideas for chemical recipes that could be useful to a cataclysm survivor, please do comment and I'll see if I can get it done.