Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ding dong the player class is dead!! #51081

Merged
merged 3 commits into from
Aug 26, 2021
Merged

Ding dong the player class is dead!! #51081

merged 3 commits into from
Aug 26, 2021

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Aug 25, 2021 •
edited
Loading

Summary

Infrastructure "The final blow in the war on player"

Purpose of change

Fix #34721
With this the player class is no more.

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@Ramza13 Ramza13 requested a review from KorGgenT as a code owner August 25, 2021 21:42
@actual-nh actual-nh added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Aug 25, 2021
@kevingranade kevingranade merged commit 270f6c5 into CleverRaven:master Aug 26, 2021
@Ramza13 Ramza13 deleted the final_blow branch August 26, 2021 04:20
@chrispikula chrispikula mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KorGgenT KorGgenT Awaiting requested review from KorGgenT

Assignees
No one assigned
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organization: the deprecation of the player class
3 participants
@Ramza13 @kevingranade @actual-nh