Adds ability to run effect_on_conditions on either avatar or npc death. #51890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Adds ability to run effect_on_conditions on either avatar or npc death."
Purpose of change
Adds ability to run effect_on_conditions on either avatar or npc death.
This allows targeted epilogue style messages, though at present they are distinct from and do not replace the actual epilogue screen. Also, as shown in the test code, it allows creating json to switch to controlling a follower on death.
Request from I-am-erk on discord for usage making refugees react to each others deaths and suggestion about controlling follower on death.
Describe the solution
There were too many effect_on_condition bools so I made them an enum for sanity. Added new types for running on either current avatars death or npcs.
Describe alternatives you've considered
Testing
Used this json
Additional context