Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine size affects power fix #5277

Merged
merged 1 commit into from Dec 30, 2013
Merged

Engine size affects power fix #5277

merged 1 commit into from Dec 30, 2013

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2013

While digging around in the code, I noticed that engine bigness is supposed to affect engine power - it's not just flavor text. The code for this was actually committed back in February, but was never called due to a typo in a bitflag mapping.

After fixing the typo, a few other minor issued cropped up, such as some vehicles being underpowered, which I've also addressed in this PR.

-fixed typo in bitflag map, which prevented engine size from affecting engine power
-fixed a couple power checks that weren't going through part_power()
-removed power ratings from gas engines in vehicle_parts.json, since they are no longer used
-adjusted size ranges for gas engines
-ambulance, armored_car, and policecar now use engine_v8 instead of engine_v6```

…g engine power

-fixed a couple power checks that weren't going through part_power()
-removed power ratings from gas engines in vehicle_parts.json, since they are no longer used
-adjusted size ranges for gas engines
-ambulance, armored_car, and policecar now use engine_v8 instead of engine_v6
@ianestrachan
Copy link
Contributor

This should fix #4179, then.

@kevingranade kevingranade merged commit a5bf3ea into CleverRaven:master Dec 30, 2013
@ghost ghost deleted the engine_size_affects_power_fix branch April 9, 2014 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants