Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Workaround for linking error w/ clang & glibc 2.31+" #54241

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

BrettDong
Copy link
Member

Summary

None

Purpose of change

This removes the workaround to linking error when compiling with LLVM/Clang on a system with glibc version 2.31 or newer (#47099). The linking error only occurs when -ffast-math is used, but the flag was removed in 71c718a in #50390, so this workaround is no longer needed.

Describe the solution

Revert #47099.

Describe alternatives you've considered

Testing

Additional context

@BrettDong BrettDong added Code: Build Issues regarding different builds and build environments OS: Linux Issues related to Linux operating system labels Jan 10, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 10, 2022
Copy link
Member

@akrieger akrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if we ever measured how much -ffast-math improved performance / removing it dropped performance. -fno-builtin probably has some nontrivial cost associated with it also, so maybe it balances out :)

@kevingranade
Copy link
Member

It basically doesn't matter because we ran into --fast-math actually causing incorrect behavior, it seemed worth doing because it was "free", but I didn't anticipate the kind of failure modes it could trigger.
Hypothetically we could enable some of the sub-options that --fast-math bundles, but I don't anticipate it being meaningful, we mostly just eschew floating point operations.

@anothersimulacrum
Copy link
Member

IIRC, @jbytheway talked about it causing a slowdown in lighting that #44558 would likely be the solution to.

@kevingranade
Copy link
Member

Yea I need to get back on that, it was really promising.

@ZhilkinSerg ZhilkinSerg merged commit 2fa0fcd into CleverRaven:master Jan 11, 2022
@BrettDong BrettDong deleted the glibc branch January 11, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Build Issues regarding different builds and build environments json-styled JSON lint passed, label assigned by github actions OS: Linux Issues related to Linux operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants