Random encounter 2: refugee center visitors #56940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This begins the work, eventually will split this to a few files. Also updates with region groundcovers because obviously.
Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru>
Prevents player from forcing a respawn by constantly coming and going from the map.
Contents should still be adjusted a bit.
I-am-Erk
added
NPC / Factions
github-actions
bot
added
Map / Mapgen
* updated johns gear * woops deleted everything * don't need the camel group anymore
…_visitor.json to data/json/npcs/random_encounters/john_bailey.json
This comment was marked as resolved.
This comment was marked as resolved.
|
Well, this seems to be working pretty well, but still some things I'd like to work on at least in the long term. I'll leave this free to merge but if I have time I might fine tune it. |
github-actions
bot
added
the
BasicBuildPassed
Now he'll teach a random number of times but usually 2-3
github-actions
bot
removed
the
BasicBuildPassed
Remove the random it was causing problems
github-actions
bot
added
the
BasicBuildPassed
Drew4484
pushed a commit
to Drew4484/Cataclysm-DDA
that referenced
this pull request
May 1, 2022
* Add nested map infrastructure This begins the work, eventually will split this to a few files. Also updates with region groundcovers because obviously. * Update roadstop.json * Update roadstop.json * Update roadstop.json * Update roadstop.json * Update roadstop.json * Update roadstop.json * dialogue * Update free_merchant_caravans.json * cleanup after playtesting * Add NPC remove script by Mylie * astyle * Apply suggestions from code review Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru> * Update NPC_free_merchant_shopkeep.json * change recurrence type Prevents player from forcing a respawn by constantly coming and going from the map. * Make the pickup custom Contents should still be adjusted a bit. * Update factional.json * Update NPC_free_merchant_shopkeep.json * Update free_merchant_caravans.json * Update randenc_caravans.json * begin making some more simple NPCs * Update NPC_visiting_scavenger.json * Update NPC_visiting_scavenger.json Adds directions to many factions, similar to the teamster. * Update NPC_john_bailey_visitor.json * Some of John's dialogue * more dialogue for john * almost done John's dialogue probably got that arithmetic function wrong though * Add teaching and advice * updated johns gear (CleverRaven#25) * updated johns gear * woops deleted everything * don't need the camel group anymore * touch up arithmetic * Update NPC_john_bailey_visitor.json * Update NPC_john_bailey_visitor.json * clear change to roadstop * Rename data/json/npcs/refugee_center/surface_visitors/NPC_john_bailey_visitor.json to data/json/npcs/random_encounters/john_bailey.json * Create randenc_refugee_center.json * Update john_bailey.json * Update john_bailey.json * playtest fixes * Update randenc_refugee_center.json * Update NPC_visiting_scavenger.json * Make john able to teach more than once Now he'll teach a random number of times but usually 2-3 * Update john_bailey.json Remove the random it was causing problems Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru> Co-authored-by: Dillon Matchett <dillon.matchett@gmail.com>
|
Not sure how to report bugs, but I just had 3 visitors and 2 different John Bailey's in front of smoke. The two John Bailey's seem to have different stats when you look at them through dialog. |
|
That is exceedingly odd. Can you post that as an issue with screenshots, please? |
This was referenced May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Some visitors can randomly appear in the refugee center"
Purpose of change
Random encounters can be things on the roadside, but the framework can also be used to create the feel of people coming and going from central sites, creating a significantly more "alive" feel in this dead world.
Describe the solution
Adds a random NPC who shows up in the refugee front area, and a persistent one John Bailey who is connected to a faction much like yours. Should also add his traveling companion and their bikes but I may not add that this PR.
John Bailey: A competent and friendly survivor/scavenger who seems to have been through some stuff, John has a lot of useful skills and is willing to teach you. Since he only shows up randomly and you can't find him very often, he should be a pretty cool find when he does pop up, and in turn that may encourage people to chat with random NPCs.
Random scavenger: Random spawning scavengers have some more generic dialogue but get a random selection of a faction or point of interest to direct you to. I'd like to expand the list to include some points of interest that are not factions, to help differentiate them from the teamster.
Describe alternatives you've considered
I may get around to adding some more context to John Bailey this round too.
Testing
Seems to work. Conversations and missions tested. Unable to easily test random spawning but as best I can tell it seems to be functioning
Additional context
I am having fun getting back into writing