Allow customization of text input UI hotkeys #57266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
ZhilkinSerg
reviewed
Aug 21, 2022
| } else if( action == "PAGE_UP" ) { | ||
| if( filtered_registered_actions.empty() ) { | ||
| // do nothing | ||
| } if( scroll_offset >= display_height ) { |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Allow customization of text input UI hotkeys using either ? or F1"
Purpose of change
Allow customizing the hotkeys of text input UIs.
Describe the solution
Various text input UIs in the game now handle input using actions instead of hardcoded hotkeys.
String input popup and string editor window now use
F1as the hotkey to bring up the keybindings menu to avoid conflicting with text input, butuilist, keybindings menu, and world creation menu still use the previous default of?.The hotkeys one most likely would want to change are those for the "clear text", "paste", and "input from file" actions, but other hotkeys are still changed into actions in case someone cannot type the default hotkeys.
Testing
Tested in the tiles and curses builds and in all the affected menus (string input popup, string editor window, keybindings menu, world creation menu, and
uilist).