Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some UI fixes #57361

Merged
merged 3 commits into from
May 3, 2022
Merged

Some UI fixes #57361

merged 3 commits into from
May 3, 2022

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented May 2, 2022

Summary

None

Purpose of change

  1. Fix mouse-selected line of uilist not updated in map editing menus;
  2. FIx mouse clicks in uilist selecting the wrong line due to uncleared drawn rectangle values;
  3. Do not move cursor in string input popup when IME preview is active on tiles;
  4. Place curses window cursor at the shown cursor location during text input (for IME preview to display at the correct location, and might also help screen readers).

Describe the solution

  1. Update selected line index on mouse selection;
  2. Clear drawn rectangle values before redraw;
  3. Ignore directional keys when IME preview is active;
  4. Store the cursor location and move the curses window cursor to the stored location before final refreshing.

Testing

Tested on tiles and curses and all fixes worked as intended.

Qrox added 3 commits May 2, 2022 13:35
1. Fix selected line not updated when query is called again
2. Fix mouse click selecting the wrong line due to uncleared drawn rectangle values
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 2, 2022
@dseguin dseguin merged commit 5fd4bfe into CleverRaven:master May 3, 2022
@Qrox Qrox deleted the ui-fixes branch May 8, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants