A good night sleep is healthy

[Fris0uman]

Summary

Balance "A good night sleep is healthy"

Purpose of change

Part of #37446

Describe the solution

• get the rate fo fatigue recovery
• compute effective_time_slept as time_slept_between_update * fatigue._recovery_rate
• every turn if we were sleeping last turn add effective_time_slept to daily_sleep
• every turn if we were sleeping last turn add effective_time_slept to continuous_sleep
• on the turn we woke up check how long continuous_sleep is, if it's more than 6_hours record a "sleep_health_mult" value of 2
• reset continuous_sleep to 0
• every 12_hours add daily_sleep * sleep_health_mult number of hours to daily_health with a cap of +10
• and set "sleep_health_mult" value to 1
• every 24_hours set daily_sleep to 0

Describe alternatives you've considered

Also use value to store daily_sleep and continuous_sleep instead of adding two new variables to character

Testing

• load new world
• go to bed from 9pm to 4 am
• wait untill noon > healthy_mod is at 9 instead of 0

Additional context

effective_time_slept takes mutation, pain, and hibernation into account. However in my test setting a debug breakpoint just after it's computed show it was 1 even for an elfe with Tireless mutation, so I don't know what was happening there

[Termineitor244]

Trait that reduce the need for sleep, don't factor here. I'm not sure how to add that.

You could factor them by giving additional turns in daily_sleep and continuous_sleep for those mutations every x turns too, so they don't need to sleep the same as everyone else (while they can't do it).

[I-am-Erk]

I'd have reduced sleep mutations change the number of turns we add to daily_sleep unless you have no need to sleep at all, in which case we could either give a passive +5 health every 12 hours, or we could have daily sleep apply to resting

[Inglonias]

Is there a particular reason this PR has stalled out, or has it just slipped through the cracks?

[kevingranade]

There's some issue wuth basic build.

[kevingranade]

Possibly kill this pr and push the branch to a new one? No idea why the build cancels.

[Fris0uman]

I think we're good now and the failure are unrelated to this PR