Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solar panel crafting #57891

Merged
merged 2 commits into from Jun 18, 2022

Conversation

actually-a-cat
Copy link
Contributor

@actually-a-cat actually-a-cat commented May 24, 2022

Summary

Balance "Update solar panel crafting"

Purpose of change

Solar panel crafting is gamey. In particular, upgraded solar panels are made by somehow fitting more cells into the same panel area to double output.

Describe the solution

  • Upgraded solar panels are now "advanced solar panels", structurally the same as regular solar panels, but made with advanced solar cells (new item). You can no longer fuse two regular panels into one with the same tile coverage but double the output through the magic of fabrication 10.
  • Crafting advanced solar panels is closer in difficulty to regular panels, since they are mostly the same.
  • Crafting reinforced advanced solar panels is exactly the same as regular reinforced panels, since the type of cell inside doesn't affect how difficult it is to put stronger glass on top. (This is a big change, the recipe goes from fab 10 and rare book to autolearned fab 2)
  • Added advanced folding solar panel
  • Updated descriptions
  • Updated vehicle drag test to account for advanced solar panels being a bit lighter than before

Describe alternatives you've considered

Better panels might also have better power conversion electronics (e.g. MPPT) but we don't have the electronic parts to represent that and it feels unnecessary

Testing

Loaded game, looked at items and recipes. Installed the new folding panel in a vehicle and verified power output.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Vehicles Vehicles, parts, mechanics & interactions Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions labels May 24, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A small electronic device that can convert solar radiation into electric power. This one is a common, inexpensive type made of polycrystalline silicon.
  • Electronic device that can convert solar radiation into electric power, mounted on a folding frame. This one is a common, inexpensive type made with polycrystalline silicon cells.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 24, 2022
@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 24, 2022
@Naadn
Copy link

Naadn commented May 25, 2022

Maybe add the new solar cell to some itemgroup? So player can collect them instead only able looking for a rare vehicle

@TheShadowFerret
Copy link
Contributor

TheShadowFerret commented May 25, 2022

In particular, upgraded solar panels are made by somehow fitting more cells into the same panel area to double output

Are we sure these advanced solar panels should be twice as powerful(i.e. does monocrystalline have double efficacy versus polycrystalline silicon cells)?

@actually-a-cat
Copy link
Contributor Author

actually-a-cat commented May 26, 2022

@Naadn I've been thinking about it but if anything I'm leaning more towards removing existing spawns of solar cells. As far as I'm aware nobody is routinely doing component-level repairs on solar panels, so it doesn't make much sense to have bare cells in spare part stockpiles. Maybe they could be in light industries where solar panels would be manufactured.

@TheShadowFerret Double isn't right (it's too much) but I don't want to go into the usage side of solar panel balance with this one since that has much more impact on actual gameplay. It's not outrageous enough to make me uncomfortable with keeping the status quo. (I actually think maybe the basic panels need a buff more than the advanced need a nerf, 50W for a panel that vaguely covers a vaguely 1m2 tile is poor performance, even for pessimistic values of the vaguelys)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants