Stop loading on duplicate definition from same mod #58542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't allow the game to complete loading if an object is defined twice, as objects being defined twice is likely to cause more errors.
anothersimulacrum
added
Code: Infrastructure / Style / Static Analysis
github-actions
bot
added
astyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Make it easier to determine when a duplicate entry is the source of an error.
Describe the solution
Halt loading the game when a duplicate entry is found, instead of having a debugmsg and continuing.
Testing
Copy the definition of the item. See the game does not load, and gives an appropriate error.