Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fabric composition of army clothing to match ACU/ECWS spec #58628

Merged
merged 1 commit into from Jun 22, 2022

Conversation

Ilurker
Copy link
Contributor

@Ilurker Ilurker commented Jun 22, 2022

Summary

Balance "Update of army outerwear to match currently used fabric compositions"

Purpose of change

The current army clothing makes extensive use of plastic and cotton blends, in such a way that implies heavy use of rigid plastics. This has created some bugs, such as incorrectly inheriting the rigid quality, as well as generally departing from realism. This PR aims to bring the current composition of the outerwear items in line with current ACU/ECWS specifications.

Describe the solution

Updated fabric compositions in line with the specs associated with each item's NSN. Added the waterproof tag to the army winter pants to both bring it in line with the winter jacket, and to reflect that the ECWS uses a waterproof, three layer gore-tex specification.

Describe alternatives you've considered

Overriding incorrect rigidity inheritance by utilizing the "SOFT" and "ALLOWS_TAIL" flags.

Testing

Spawned all items and verified they had correct fabric compositions and expected inherited qualities.

Additional context

Data pulled wherever possible from publicly available military specifications:

NSN 8415-01-577-1146
NSN 8415-01-526-9168
NSN 8415-01-548-7209

MIL-DTL-32185
MIL-DTL-32184
MIL-DTL-44436

Specs as actually readable without opening 45 standards documents to decipher them can be gleaned from the following sources:

https://www.army.mil/article/66527/fight_the_freeze

https://store.armyproperty.com/products/trousers-ecwcs-gen-ii-medium-regular-nsn-8415-01-526-9062.html
https://store.armyproperty.com/products/parka-ecwcs-gen-ii-x-small-x-short-nsn-8415-01-526-9168.html
https://store.armyproperty.com/products/army-combat-shirt-rfi.html
https://sites.google.com/site/unitedstatesmilitarycollection/army-combat-uniform-acu
https://quicksearch.dla.mil/qsDocDetails.aspx?ident_number=107457

Essentially, standard ACU uses a composition of 50% cotton, 50% rip-stop (which is, in turn, 50% cotton and 50% nylon), yielding a 25/75 cotton-synthetic split. The ECWS cold weather items use a three-layer system of nylon, gore-tex, and nylon again, without natural materials. These items are explicitly waterproof in nature and have high breathability.

While researching this, I discovered that there are commonly available flame-resistant variations of all items, utilizing para-aramid weave. It might be appropriate to add nomex-containing variants of army clothing in a seperate PR.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing Game: Balance Balancing of (existing) in-game features. labels Jun 22, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 22, 2022
Copy link
Contributor

@bombasticSlacks bombasticSlacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dseguin dseguin merged commit 9031a6e into CleverRaven:master Jun 22, 2022
@Ilurker Ilurker deleted the army-clothing-fabric branch June 22, 2022 19:52
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 22, 2022
Drew4484 pushed a commit to Drew4484/Cataclysm-DDA that referenced this pull request Jun 24, 2022
Drew4484 pushed a commit to Drew4484/Cataclysm-DDA that referenced this pull request Jun 24, 2022
a-chancey pushed a commit to a-chancey/Cataclysm-DDA that referenced this pull request Jun 24, 2022
tornikeo pushed a commit to tornikeo/Cataclysm-DDA that referenced this pull request Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants